Put sync.Mutex on top of variables it protects. #396
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the code more consistent with the
rateMu
below.This is a followup to #390 (comment).
I've also considered an alternative solution that kept the comments on top
or
but decided to go with the inline version because I figured these are internal implementation details and unexported variables, so it's fine.
If there's any preference towards keeping the comments on top, I'm happy to change it back.