Add the maintainer_can_modify option to the PullRequest structs #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mie
added a commit
to HippieStation/PRMirror
that referenced
this pull request
Mar 11, 2017
Add a function to dump the DB Add itob and btoi, remove IntToByteArray Clean up Erik's shitty DB functions Begin to start creating PRs on InitialCreate (need Google to merge a fix for this to work though, google/go-github#590)
dmitshur
approved these changes
Mar 11, 2017
There was a problem hiding this comment.
This is a great PR (best viewed ignoring whitespace via https://github.com/google/go-github/pull/590/files?w=1, btw). I don't see any issues, and I don't have any suggestions for improvement. Thanks @JamieH!
LGTM.
The only thing I can think of is you could consider exercising the new pullRequestUpdate.MaintainerCanModify field in TestPullRequestsService_Edit test. But it's fine either way, up to you.
Also, we got lucky that the same field was added to the big PullRequest struct (can be seen at the bottom of the example at https://developer.github.com/v3/pulls/#get-a-single-pull-request), so the fact Edit uses pull *PullRequest parameter did not create a problem.
|
Thanks :) |
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #589