(#715) Add test for anomalous timestamp format from Projects API. #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlewis
approved these changes
Sep 11, 2017
|
@shurcooL Any word on this? 😀 |
dmitshur
approved these changes
Sep 20, 2017
| referenceUnixTimeStr = `1136214245` | ||
| emptyTimeStr = `"0001-01-01T00:00:00Z"` | ||
| referenceTimeStr = `"2006-01-02T15:04:05Z"` | ||
| referenceTimeStrFractional = `"2006-01-02T15:04:05.000Z"` // This format was returned by the Projects API before October 1, 2017. |
There was a problem hiding this comment.
GitHub announcement says:
Starting on Monday October 2nd, 2017
So, wouldn't it be more accurate to say this?
-before October 1, 2017.
+before October 2, 2017.At least I parse "before day X" to mean "before and not including day X" rather than "before and also on day X".
But this is extremely insignificant.
nbareil
pushed a commit
to nbareil/go-github
that referenced
this pull request
May 1, 2018
This PR adds a test case verifying that timestamp strings in the "2006-01-02T15:04:05.000Z" format are converted properly into github.Timestamp by JSON unmarshaling. This is related to the minor GitHub API change described at https://developer.github.com/changes/2017-09-01-breaking-changes-to-projects-api-preview-and-webhooks-date-format/. Fixes google#715.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test logic verifying that timestamp strings in the
"2006-01-02T15:04:05.000Z"format are converted properly intoTimestampsby JSON unmarshalling.Fixes #715.