-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add parent team id param #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmitshur
merged 12 commits into
google:NestedTeamsPreview
from
elliott-beach:add-parent-team-id-param
Oct 3, 2017
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0346f43
Add the NewTeam struct.
elliott-beach 9c6a714
Use NewTeam param in CreateTeam, EditTeam
elliott-beach 3679a4c
Remove LDAPDN from NewTeam
elliott-beach 44ea27e
remove whitespace
elliott-beach 117c8b3
go generate
elliott-beach 9763dd9
simplify string to string pointer
elliott-beach eaa244b
struct NewTeam: remove id, make Name required
elliott-beach d8dcf77
add testHeader to EditTeam
elliott-beach eb38245
Add LDAPN to NewTeam
elliott-beach 94ed0c7
fix style
elliott-beach 239f3f6
Add deprecation notice, style
elliott-beach 235698d
add string convience method to NewTeam
elliott-beach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd that the
EditTeam
endpoint requires both a name and an id for the team, but that is the documented behavior.