Skip to content

Add RepositoriesService.GetCommitRaw method. #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2017
Merged

Add RepositoriesService.GetCommitRaw method. #767

merged 1 commit into from
Oct 30, 2017

Conversation

dmitshur
Copy link
Member

Follows the same high-level pattern as set out in PR #481 with PullRequestsService.GetRaw method. (/cc @huydx FYI.)

Improve documentation wording.

Improve style of PullRequestsService.GetRaw and its tests to be more consistent.

Fix minor typo in GitHub documentation URL.

@dmitshur
Add RepositoriesService.GetCommitRaw method.
09300aa 
Follows the same high-level pattern as set out in PR #481 with
PullRequestsService.GetRaw method.

Improve documentation wording.

Improve style of PullRequestsService.GetRaw and its tests to be more
consistent.

Fix minor typo in GitHub documentation URL.
@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Oct 29, 2017
@huydx
Copy link
Contributor

huydx commented Oct 30, 2017

LGTM~

gmlewis
gmlewis approved these changes Oct 30, 2017
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @shurcooL!

I'm not sure I see the minor GitHub URL typo that you fixed, but no big deal.

@dmitshur
Copy link
Member Author

I'm not sure I see the minor GitHub URL typo that you fixed, but no big deal.

It's this change in github/repos_commits.go file:

image

@dmitshur dmitshur merged commit 724ae38 into master Oct 30, 2017
@dmitshur dmitshur deleted the add-GetCommitRaw branch October 30, 2017 21:24
@dmitshur
Copy link
Member Author

Thank you for reviewing; merged.

@dmitshur dmitshur mentioned this pull request Nov 5, 2017
Closed
@dmitshur dmitshur mentioned this pull request Nov 17, 2017
Closed
@kshitij10496 kshitij10496 mentioned this pull request Jan 18, 2018
Closed
@dmitshur dmitshur mentioned this pull request Apr 11, 2018
Merged
nbareil pushed a commit to nbareil/go-github that referenced this pull request May 1, 2018
@dmitshur
Add RepositoriesService.GetCommitRaw method. (google#767)
3791171 
Follows the same high-level pattern as set out in PR google#481 with
PullRequestsService.GetRaw method.

Improve documentation wording.

Improve style of PullRequestsService.GetRaw and its tests to be more
consistent.

Fix minor typo in GitHub documentation URL (2 slashes instead of 1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitshur @huydx @gmlewis @googlebot