Replace int id with int64 in OrganizationsService
#883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
You're right. There's a few extra I found:
Would you like to expand the scope of your PR and fix those instances as well? If not, np, we can do it as part of a separate PR. |
|
Yeah I can add those too
|
dmitshur
added a commit
to shurcooL/issues
that referenced
this pull request
Mar 29, 2018
gopherbot
pushed a commit
to golang/build
that referenced
this pull request
Mar 30, 2018
When editing a comment, the current code used the issue number in place of the comment ID. But the EditComment endpoint needs the comment ID. The issue number is not needed at all in updateGithubComment because the EditComment endpoint uses the repository and comment ID to uniquely identify the comment. References: - https://developer.github.com/v3/issues/comments/#edit-a-comment. - https://godoc.org/github.com/google/go-github/github#IssuesService.EditComment. Updates golang/go#24598. Updates google/go-github#883. Updates google/go-github#597. Change-Id: Iae9d967d7be7a75b1bcee7118a3c80fe8f2375b4 Reviewed-on: https://go-review.googlesource.com/103398 Reviewed-by: Brad Fitzpatrick <[email protected]>
nbareil
pushed a commit
to nbareil/go-github
that referenced
this pull request
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the OrganizationsService didn't get converted in the int -> int64 id migration.
Updates #597.