Skip to content

Update the transfer repository request to use the correct json name #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2018
Merged

Update the transfer repository request to use the correct json name #947

merged 1 commit into from
Jul 12, 2018

Conversation

juliaferraioli
Copy link
Contributor

...for team IDs.

I didn't change the variable name to keep consistent with the create org invitation options.

Fixes #946

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 12, 2018
gmlewis
gmlewis approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @juliaferraioli!

dmitshur
dmitshur approved these changes Jul 12, 2018
View reviewed changes
Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dmitshur dmitshur merged commit e96f1f1 into google:master Jul 12, 2018
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Aug 10, 2018
@juliaferraioli @gmlewis
Use "team_ids" JSON name for TransferRequest.TeamID field (google#947)
a7fdc65 
According to GitHub API docs at https://developer.github.com/v3/repos/#transfer-a-repository,
the field name should be "team_ids". This change updates it to match.

Fixes google#946.
Updates google#788.
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@juliaferraioli @dmitshur
Use "team_ids" JSON name for TransferRequest.TeamID field (google#947)
2108cbc 
According to GitHub API docs at https://developer.github.com/v3/repos/#transfer-a-repository,
the field name should be "team_ids". This change updates it to match.

Fixes google#946.
Updates google#788.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitshur dmitshur dmitshur approved these changes

+1 more reviewer

@gmlewis gmlewis gmlewis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliaferraioli @dmitshur @gmlewis @googlebot