Skip to content

Fixes wrong Accept media type that was causing a 500 #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

phylake
Copy link
Contributor

@phylake phylake commented Aug 14, 2018

https://developer.github.com/v3/issues/#list-issues-for-a-repository
lists

  • application/vnd.github.symmetra-preview+json
  • application/vnd.github.squirrel-girl-preview
  • application/vnd.github.machine-man-preview

which map to

  • mediaTypeLabelDescriptionSearchPreview
  • mediaTypeReactionsPreview
  • mediaTypeIntegrationPreview

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Aug 14, 2018
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 14, 2018

Thank you, @phylake! Could you please also update the corresponding test?

This PR generates the Travis CI failure:

	github_test.go:115: Header.Get("Accept") returned "application/vnd.github.squirrel-girl-preview, application/vnd.github.symmetra-preview+json, application/vnd.github.machine-man-preview+json", want "application/vnd.github.squirrel-girl-preview, application/vnd.github.symmetra-preview+json, application/vnd.github.sailor-v-preview+json"

If you run go test ./... locally, you should see the problem.

https://developer.github.com/v3/issues/#list-issues-for-a-repository
lists
- application/vnd.github.symmetra-preview+json
- application/vnd.github.squirrel-girl-preview
- application/vnd.github.machine-man-preview

which map to

- mediaTypeLabelDescriptionSearchPreview
- mediaTypeReactionsPreview
- mediaTypeIntegrationPreview
@phylake
Copy link
Contributor Author

phylake commented Aug 29, 2018

I think Travis CI failed to update the status check. It all looks green to me. What should I do?

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 29, 2018

I restarted the build... Let's see if that fixes it.

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 29, 2018

That seems to have worked.

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 29, 2018

It looks like this was mistakenly changed in #910.
Thank you for catching and fixing this, @phylake!
LGTM.
Merging.

@gmlewis gmlewis merged commit 3dd825b into google:master Aug 29, 2018
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants