Add verbatim string support #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
approved these changes
Aug 10, 2017
sparkprime
reviewed
Aug 14, 2017
| @@ -346,6 +346,8 @@ func (p *parser) parseObjectRemainder(tok *token) (astNode, *token, error) { | |||
| kind: astStringBlock, | |||
| blockIndent: next.stringBlockIndent, | |||
| } | |||
| // TODO(sbarzowski) are verbatim string literals allowed here? | |||
There was a problem hiding this comment.
Yes they should be allowed everywhere other string literals are allowed.
There was a problem hiding this comment.
I see there is no test for it and it doesn't work in C++:
$ jsonnet -e '{@"foo": 3}'
STATIC ERROR: <cmdline>:1:2-7: Unexpected: VERBATIM_STRING_DOUBLE while parsing field definition
There was a problem hiding this comment.
It does work in import, but there is also no test for that
There was a problem hiding this comment.
See also: google/jsonnet#172
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.