Better importing (caching & public API) #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was a side-effect of the work on the Linter which needs to go through imports to be really useful. |
sparkprime
reviewed
Sep 10, 2019
imports.go
Outdated
| @@ -97,6 +110,21 @@ func (cache *importCache) importData(importedFrom, importedPath string) (content | |||
| return | |||
| } | |||
|
|
|||
| func (cache *importCache) importAST(importedFrom, importedPath string) (ast.Node, string, error) { | |||
| // TODO(sbarzowski) perhaps we can cache the AST, so that we go through parsing twice | |||
There was a problem hiding this comment.
This comment doesn't make sense
|
Seems reasonable to expose this. |
sbarzowski
force-pushed
the
better-imports
branch
from
126ebb6 to
f80e225
Compare
* It adds new API which allows using VM for importing files in external tools "just as Jsonnet would". This is primarily intended for use in static analysis tools. * Imports are now cached between evaluate calls. This may improve performance significantly for some users. I would like to add some way of achieving this with commandline in the future. * Additional layer of caching was internally added - AST level. This was necessary so that Jsonnet could always return the same exact AST when asked multiple times (meaning the same pointers).
sbarzowski
force-pushed
the
better-imports
branch
from
f80e225 to
7fb5d80
Compare
|
I fixed that obsolete comment, another typo, and a bug ( @sparkprime Do you want to take another look at it? |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files in external tools "just as Jsonnet would". This is
primarily intended for use in static analysis tools.
performance significantly for some users. I would like to add
some way of achieving this with commandline in the future.
This was necessary so that Jsonnet could always return the same
exact AST when asked multiple times (meaning the same pointers).