Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Conversation

zdunecki
Copy link
Contributor

Currently, this lib doesn't allow to choose custom monitored resources. It's a useful feature to match the machine where do metrics come from.

@google-cla
Copy link

google-cla bot commented Dec 22, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@zdunecki
Copy link
Contributor Author

@googlebot I signed it!

@tam7t
Copy link
Contributor

tam7t commented Dec 28, 2020

Thanks for the contribution, I have limited availability right now but hope to review on/by 8 January.

@zdunecki
Copy link
Contributor Author

@tam7t, thanks for CR and tips. I guess I resolved all.

@tam7t tam7t merged commit 12f414d into google:main Jan 22, 2021
@tam7t
Copy link
Contributor

tam7t commented Jan 22, 2021

Thanks, I'll try to cut a v0.3.0 release with this in it, but I'm going to try doing some manual integration testing first but in the meantime i think you should be able to do like:

go get github.com/google/go-metrics-stackdriver@12f414d48a0fbe8802005bc082c6a9345e9c5e12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants