Skip to content

Wildcard import should return failure for dry run #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santhoshTpixler opened this issue Aug 7, 2019 · 2 comments
Closed

Wildcard import should return failure for dry run #392

santhoshTpixler opened this issue Aug 7, 2019 · 2 comments

Comments

@santhoshTpixler
Copy link

WRT #113 It is not possible to expand the wildcards in the import statements. But the dry run should report that there are changes to needed to comply with the Google java code style.

We use java -jar google-java-format-1.7-all-deps.jar --set-exit-if-changed -n $(find . -type f -name "*.java") in the CI to verify the code formatting. But wildcards in the import statement does not affect the exit code. This leads to code being accepted even if it is not in Google java code style(Only wild card imports).

@awturner
Copy link
Contributor

awturner commented Aug 13, 2019

There are lots of things that violate the style guide which aren't detected by GJF. For example, the rule that overloads should appear together, or optional braces.

GJF fixes whitespace/wrapping issues only.

@cushon cushon closed this as completed Aug 15, 2019
@awturner
Copy link
Contributor

awturner commented Aug 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants