You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
WRT #113 It is not possible to expand the wildcards in the import statements. But the dry run should report that there are changes to needed to comply with the Google java code style.
We use java -jar google-java-format-1.7-all-deps.jar --set-exit-if-changed -n $(find . -type f -name "*.java") in the CI to verify the code formatting. But wildcards in the import statement does not affect the exit code. This leads to code being accepted even if it is not in Google java code style(Only wild card imports).
The text was updated successfully, but these errors were encountered:
To be fair, I think that the description is misleading:
"""
google-java-format is a program that reformats Java source code to comply
with Google Java Style.
"""
Saying "reformats **whitespace in** Java source code" would make the scope
of GJF clearer.
On Thu, 15 Aug 2019, 16:11 Liam Miller-Cushon, ***@***.***> wrote:
Closed #392 <#392>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#392?email_source=notifications&email_token=ACGZEZAS6C76JT5AONKL22DQEVW2TA5CNFSM4IJ6BRL2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTCJW57I#event-2559799037>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACGZEZESGQIHR3DYXU2MTYLQEVW2TANCNFSM4IJ6BRLQ>
.
WRT #113 It is not possible to expand the wildcards in the import statements. But the dry run should report that there are changes to needed to comply with the Google java code style.
We use
java -jar google-java-format-1.7-all-deps.jar --set-exit-if-changed -n $(find . -type f -name "*.java")
in the CI to verify the code formatting. But wildcards in the import statement does not affect the exit code. This leads to code being accepted even if it is not in Google java code style(Only wild card imports).The text was updated successfully, but these errors were encountered: