-
Notifications
You must be signed in to change notification settings - Fork 470
ios 13 support changes - Perfecto contribution #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
I signed it! |
CLA for Perfecto Mobile has been completed. |
When is this likely to go live? |
hi @mickelluchko, thanks for contribution! PR needs some cleanup: unnecessary comments should be stripped, code duplications removed, I'm sure global variables could be avoided, etc. Also please stick to original code formatting |
no problem |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Any timelines when this is gonna be merged..!! |
Any updates on this? iOS 13 is out now.... |
Someone please fix this problem. I have been waiting for a very long time. No more strength to wait. I'm exhausted. |
@Pavel-DV it's an open source project, you're always welcome to contribute. this PR is very hacky, it does break functionality and can't be merged without extra work |
Work is in progress. ETA is next Monday |
Hello, any updates on the PR? Is it going to be merged soon? Thanks |
@vasogiamarelou almost there, I think tomorrow beta will be out UPD: a bit more required, new ETA is this weekend |
As of iOS 13, Apple requires SSL connection with Web inspector.
Changes tested on Mac OS X Mojave (libimobiledevice master) with latest appium server on an iPhone running iOS 13 beta 3.