Public Marshal API Simplification #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Included, MarshalOne, MarshalManyPayload, MarshalManyPayloadWithoutIncluded, MarshalMany - now there are only 3: MarshalPayload, MarshalPayloadWithoutIncluded, Marshal. This simplifies the public API; will be easier to explain and document while still providing the existing support for struct ptrs (&Blog{}) and slices of struct ptrs ([]*Blog{}).
aren55555
changed the title
aren55555
force-pushed
the
feature/simplifiy-marshal-api
branch
from
27cc356 to
d8473fd
Compare
shwoodard
approved these changes
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have 6 Marshal functions:
MarshalOnePayloadMarshalOnePayloadWithoutIncludedMarshalOneMarshalManyPayloadMarshalManyPayloadWithoutIncludedMarshalManyThis PR reduces the Public Marshal methods to just 3:
MarshalPayloadMarshalPayloadWithoutIncludedMarshalThis simplifies the public API; will be easier to explain and document while still providing the existing support for struct ptrs (
&Blog{}) and slices of struct ptrs ([]*Blog{}).