MatchAs #147
Merged
MatchAs #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…in Match node; 3. added corresponding unit tests Co-authored-by: Lucybean-hi <[email protected]> Co-authored-by: juliawgraham <[email protected]> Co-authored-by: Erica Fu <[email protected]>
|
will fix errors. |
|
We reran all of the CI tests for this PR and it all seems to pass |
|
Okay will check it. |
|
It looks several refactoring can be still applied before merging. As this is the blocker of a broader refactoring (#155), I will process it on behalf of you. |
added 4 commits
December 9, 2022 03:51
odashi
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatchAs is implemented and tested
Overview
All of these produce the correct latex code when a user enters a wildcard case in a python match statement. A non-empty MatchAs case will invoke an error message.
Details
Added one new function to function_codegen.py
visit_MatchAs, if there is a wildcard, create an 'otherwise' case in latex, else throw error
Added two new test cases to function_codegen_test.py
test_matchvalue_matchas_wildcard, tests if an 'otherwise' case is created in latex
test_matchvalue_matchas_nonempty, tests if an error is thrown
References
#93
Blocked by
#146