Adds 'interpolation-decay' attribute #2286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Setting the attribute affects camera smoothing and model position interpolation. * Adds 'decayMilliseconds' to Damper.update() method call.
elalish
suggested changes
Apr 15, 2021
|
Also, please mark |
…interpolation-decay-api Adds 'interpolation-decay-milliseconds' attribute * Setting the attribute affects camera smoothing and model position interpolation. * Adds 'decayMilliseconds' to Damper.update() method call.
elalish
suggested changes
Apr 15, 2021
packages/model-viewer/src/three-components/gltf-instance/ModelViewerGLTFInstance.ts
Outdated
Show resolved
Hide resolved
…interpolation-decay-api Adds 'interpolation-decay-milliseconds' attribute * Setting the attribute affects camera smoothing and model position interpolation. * Adds 'decayMilliseconds' to Damper.update() method call. Fixes #580
ghost
changed the title
elalish
suggested changes
Apr 15, 2021
…interpolation-decay-api Adds 'interpolation-decay-milliseconds' attribute * Setting the attribute affects camera smoothing and model position interpolation. * Adds 'decayMilliseconds' to Damper.update() method call. * Updates to docs Fixes #580
…interpolation-decay-api Adds 'interpolation-decay-milliseconds' attribute * Setting the attribute affects camera smoothing and model position interpolation. * Adds 'decayMilliseconds' to Damper.update() method call. * Updates to docs Fixes #580
…interpolation-decay-api Adds 'interpolation-decay-milliseconds' attribute * Setting the attribute affects camera smoothing and model position interpolation. * Adds 'decayMilliseconds' to Damper.update() method call. * Updates to docs Fixes #580
ghost
marked this pull request as ready for review
elalish
reviewed
Apr 16, 2021
* Setting the attribute affects camera smoothing and model position interpolation. * Adds 'decayMilliseconds' to Damper.update() method call. * Updates to docs * Updates to Interpolation example Fixes #580
elalish
reviewed
Apr 16, 2021
* Setting the attribute affects camera smoothing and model position interpolation. * Adds 'decayMilliseconds' to Damper.update() method call. * Updates to docs * Updates to Interpolation example Fixes #580
elalish
previously approved these changes
Apr 16, 2021
* hide rendering while new model loads * removed pointless test, minor cleanup * skipping Edge flakes temporarily
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #580