fixed renderer-harness #2757
Merged
fixed renderer-harness #2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a lot of weird flakiness in our fidelity tests that we didn't understand, so we just turned the flake into a warning so we could ignore it. However, the fidelity tests actually catch quite a few nasty regressions, so I'd rather they were all functional. I found a few sketchy things that I've fixed here. I was only able to get a consistent repro on a single model locally, and this fixed that, but we'll see if the CI agrees.
And it looks like it does! Seems the catch for the poster issue must have been somehow wrong, but there's no poster problem now and once that check was removed everything seems to be working well.