Update controls-related examples #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucadalli
commented
Sep 7, 2021
| recenter(event.changedTouches[0]); | ||
|
|
||
| if (event.cancelable) { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
Prevents emulation of mouseup event which was invoking recenter a second time.
lucadalli
commented
Sep 7, 2021
| @@ -247,8 +247,8 @@ <h4>Event listeners can cooperate with camera-controls</h4> | |||
| Math.abs(pointer.clientY - startY) > tapDistance) | |||
| return; | |||
| const rect = modelViewer.getBoundingClientRect(); | |||
| const x = event.clientX - rect.left; | |||
| const y = event.clientY - rect.top; | |||
| const x = pointer.clientX - rect.left; | |||
There was a problem hiding this comment.
Lack of type-checking bit us again. Surprisingly, the browser injects event as a variable in the event handler scope.
Try:
window.addEventListener('click', () => console.log(event))
It was working with mouse events because unlike TouchEvent, MouseEvent has properties clientX and clientY.
elalish
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates relevant examples to be in line with the changes to SmoothControls.
Favors simplicity over completeness.
For example: after swiping vertically on the panning example to scroll, it is possible to add a second touch and pan while scrolling. SmoothControls has guards against zoom while scrolling but an unsavory amount of redundancy is necessary to port them to the examples.
To avoid this, we should consider adding an API to allow for user-defined
touchModes.