updated three.js to r136 #3082
Merged
updated three.js to r136 #3082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good @mrdoob! |
|
@elalish does the 1.9.2 version of have this fix? |
|
UPDATE: I found the problem in my case which was the resolution of the textures. Thank you! I don't see black textures anymore. @elalish The model still gets rendered without textures and appears black. However, using the threejs viewer from https://github.com/mrdoob/three.js/releases does not cause the same issue as with modelviewer. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3000
Fixes #3025
Fixes #3067
The problems with textures randomly going black on iOS was tracked down to Webkit having some kind of memory leak in their
ImageBitmapimplementation. The workaround was to disable this on iOS, so their performance will be slightly worse, but at least functional again.This also adds support for the glTF sheen extension, since I added IBL support for that upstream in three.js. Note khronos-ToyCar for example.
Note this PR also lightens all the renders, bringing them closer in line with the other glTF renderers, which you can see here once this is merged: https://modelviewer.dev/fidelity/ I believe this is from switching from gamma encoding to sRGB, which probably should have happened a long time ago. If you don't like the change, you should be able to get similar results to before by using an
exposureof slightly less than 1.0.