Skip to content

Generated gRPC client method stubs get no comments or deprecation annotations #900

Closed
@calmh

Description

@calmh

It would be nice if comments on rpc:s in the proto files were passed on as comments on generated method stubs. It would also be nice if option deprecated = true resulted in a @Deprecated annotation. Currently none of these things happen; for example,

// Deprecated: use GetLatestReportV2 (1.18.3)
rpc GetLatestReport(GetLatestReportRequest) returns (AerodromeReport) {
    option deprecated = true;
}

generates as

  $grpc.ResponseFuture<$8.AerodromeReport> getLatestReport($12.GetLatestReportRequest request, {$grpc.CallOptions? options}) {
    return $createUnaryCall(_$getLatestReport, request, options: options);
  }

which the client has no idea is deprecated, and gets no guidance from a comment.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @calmh@osa1

        Issue actions

          Generated gRPC client method stubs get no comments or deprecation annotations · Issue #900 · google/protobuf.dart