replace xml/html files with asciidoc files for rendering on github #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkruse
force-pushed
the
asciidoc
branch
5 times, most recently
from
fdf0c49 to
cff2973
Compare
|
on the other hand, asciidoc does not serve as input to pandoc, not has github whitelisted the jekyll asciidoc plugin, so markdown is probably a better choice. |
tkruse
added a commit
to tkruse/styleguide
that referenced
this pull request
Feb 17, 2019
|
What happened to this change? Would not the use of Asciidoc instead of HTML be much better for future maintenance. You could build both HTML and PDF from Asciidoc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since moving the styleguides from googlecode to github, the one written in xml have become unreadable. Those written in html have always been very bad to edit and fix.
This PR applies the transformation suggested by me in #36 (1st comment).