doesn't work with node-webkit

[stevenvachon]

Because of things like this:

typeof global == 'undefined' ? this : global

which should instead be:

typeof window == 'undefined' ? global : this
// OR
typeof window != 'undefined' ? window : (typeof WorkerGlobalScope != 'undefined' ? self : global)

Browsers will always have window and possibly global with node-webkit (or similar).
Node will never have window but will always have global.

[stevenvachon]

These:

• src/runtime/ModuleStore.js#L272
• src/runtime/runtime.js#L387

Maybe these:

• test/test-utils.js#L333-L334
• test/unit/node/resources/scriptUsesModuleGlobal.js#L3

Breaks tests when changed, though, and I'm not sure how to fix them without spending 24 hours familiarizing myself with traceur's source.

[johnjbarton]

I gather that window ends up with window.global being a global symbol with node properties:
https://github.com/rogerwang/node-webkit/wiki/Transfer-objects-between-window-and-node

I'm unsure why we even use this. I think global should be global or window, but there must be some reason for this.

[arv]

I'm unsure why we even use this. I think global should be global or window, but there must be some reason for this.

this at the top level Script is the global according to ECMAScript. It works in browsers and in web workers. It just happens to fail in Node.js because they were not aware of this feature when they designed their module system which prepends the source with function(...) {.

this is also going to be the global in Modules.

Using window instead of this works in browsers but not in web workers.

[johnjbarton]

So how about (window || global || this)? Meaning "browser's global,
node's global, or ECMAScripts' global".

On Mon, Sep 15, 2014 at 8:44 AM, Erik Arvidsson notifications@github.com
wrote:

I'm unsure why we even use this. I think global should be global or
window, but there must be some reason for this.

this at the top level Script is the global according to ECMAScript. It
works in browsers and in web workers. It just happens to fail in Node.js
because they were not aware of this feature when they designed their module
system which prepends the source with function(...) {.

this is also going to be the global in Modules.

Using window instead of this works in browsers but not in web workers.

—
Reply to this email directly or view it on GitHub
#1340 (comment)
.

[stevenvachon]

@johnjbarton that will throw an error in Node as window is undefined.

[stevenvachon]

Can anyone on the traceur team look into this? If not, I'll have to spend a few days figuring it out and that will take more time than I currently have available.

[johnjbarton]

Sorry, it's not practical for me to figure out node-webkit. It sounds like the change you need is relatively localized and once you rebuild you can verify that your node-webkit use works and that make test and the runner.html web page run.

[stevenvachon]

@johnjbarton Ok. Which file loads generated-code-dependencies.js? That's where the tests are failing and I'd like to check any of its parent scopes.

[johnjbarton]

Use make test. That particular file is difficult to debug, it runs node
in a subprocess. You might console.log the argument to exec() and run it on
the command line. If you have to dive in start by printing stderr and
stdout to console.log so you don't go nuts when you don't see output.

On Wed, Sep 24, 2014 at 4:23 PM, Steven Vachon notifications@github.com
wrote:

@johnjbarton https://github.com/johnjbarton Ok. Which file loads
generated-code-dependencies.js? That's where the tests are failing and I'd
like to check any of its parent scopes.

—
Reply to this email directly or view it on GitHub
#1340 (comment)
.

[stevenvachon]

What is the purpose of ('global', eval)(src)? Why not just use eval(src)?

[johnjbarton]

To ensure that local variables are not involved in the eval.
On Sep 24, 2014 6:55 PM, "Steven Vachon" notifications@github.com wrote:

What is the purpose of ('global', eval)(src)? Why not just use eval(src)?

—
Reply to this email directly or view it on GitHub
#1340 (comment)
.

[UltCombo]

@johnjbarton Isn't ('global', eval) === eval? The comma operator simply discards the first operand AFAICS.

[johnjbarton]

This is an indirect eval.

http://stackoverflow.com/questions/9107240/1-evalthis-vs-evalthis-in-javascript
On Sep 24, 2014 7:09 PM, "Fabrício Matté" notifications@github.com wrote:

@johnjbarton https://github.com/johnjbarton Isn't ('global', eval) ===
eval? The command operator simply discards the first operand AFAICS.

—
Reply to this email directly or view it on GitHub
#1340 (comment)
.