Class methods should be non enumerable #1874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domenic PTAL |
|
|
||
| assert.isTrue(C.prototype.hasOwnProperty('0')); | ||
| assert.isTrue(C.prototype.hasOwnProperty('1')); |
There was a problem hiding this comment.
This change reduces coverage by allowing extra properties to sneak in. Maybe use gOPNs instead of O.keys?
There was a problem hiding this comment.
I had getOwnPropertyNames first but that includes arguments and caller which is wrong according to ES6.
|
LGTM with a test style nit. Interesting that we made getters nonenumerable.... Not sure I agree with that, but oh well. Thanks so much for the quick response! |
|
I double checked this PR should be in npm. Please let me know if that is not what you see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1873