Fix rotation around Y axis

[moritzblume]

Current implementation rotates clockwise which is not the norm and not consistent to the implemented X and Y rotation matrices.

This PR fixes issue #261 .

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

[moritzblume]

Any updates? When will it be merged?

[johnmccutchan]

Hi,

If you are still around I'd be interesting in merging this change.

[johnmccutchan]

Ping @moritzblume

[moritzblume]

Sure, go ahead! Do you need anything else from my side?

…

On Tue, 20 Jun 2023, 18:12 John McCutchan, ***@***.***> wrote: Ping @moritzblume <https://github.com/moritzblume> — Reply to this email directly, view it on GitHub <#262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABU37QI27FU2CCPRMGPIQDDXMHDVNANCNFSM5TYHIIMA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kevmoo]

this is causing failures in CI! https://github.com/google/vector_math.dart/actions/runs/5602301361/job/15176578907#step:9:76

[johnmccutchan]

@moritzblume We discovered two issues with the CL and so we had to revert, please address the following:

1. Broke some tests (run dart test to reproduce)
2. Made rotateY inconsistent across Matrix3 and Matrix4 classes.

For issue (1) is pretty trivial, just swapping the signs in the test expectation.
For issue (2) both Matrix3 and Matrix4 need to be updated together so they are consistent.