setup.py: Require setuptools >=58.5.0 (fixes #1107) #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 20, 2023
|
Note this is required because setup tools fixed pypa/setuptools#1461 with v58.5.0. See https://setuptools.pypa.io/en/latest/history.html#v58-5-0 |
Spitfire1900
suggested changes
Jun 21, 2023
setup.py
Outdated
| @@ -94,6 +94,9 @@ def run(self): | |||
| }, | |||
| include_package_data=True, | |||
| python_requires='>=3.7', | |||
| setup_requires=[ | |||
| 'setuptools>=58.5.0', # see issue #1107 | |||
There was a problem hiding this comment.
Suggested change
| 'setuptools>=58.5.0', # see issue #1107 | |
| 'setuptools>=58.5.0', # #1107 - include_package_data fix |
There was a problem hiding this comment.
@Spitfire1900 done
|
This will be great to improve reproducibility of builds. |
hartwork
force-pushed
the
issue-1107-require-recent-enough-setuptools
branch
from
043cd3d to
2760e2e
Compare
.. so that "python3 setup.py sdist" ends up including these four files in the resulting distribution source tarball: - /third_party/yapf_third_party/yapf_diff/LICENSE - /third_party/yapf_third_party/_ylib2to3/Grammar.txt - /third_party/yapf_third_party/_ylib2to3/LICENSE - /third_party/yapf_third_party/_ylib2to3/PatternGrammar.txt
hartwork
force-pushed
the
issue-1107-require-recent-enough-setuptools
branch
from
2760e2e to
6480174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. so that
python3 setup.py sdistends up including these four files in the resulting distribution source tarball:/third_party/yapf_third_party/yapf_diff/LICENSE/third_party/yapf_third_party/_ylib2to3/Grammar.txt/third_party/yapf_third_party/_ylib2to3/LICENSE/third_party/yapf_third_party/_ylib2to3/PatternGrammar.txtFixes #1107
CC @bwendling