Skip to content

Generate declaration files #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2017
Merged

Generate declaration files #785

merged 1 commit into from
Nov 5, 2017

Conversation

notVitaliy
Copy link
Contributor

@notVitaliy notVitaliy commented Jul 28, 2017

Generate typescript declaration files.

  • npm test succeeds
  • Pull request has been squashed into 1 commit
  • I did NOT manually make changes to anything in apis/
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate JSDoc comments were updated in source code (if applicable)
  • Approprate changes to readme/docs are included in PR

Sorry, something went wrong.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2017
@jmdobry jmdobry requested a review from JustinBeckwith August 16, 2017 21:41
@jmdobry
Copy link
Contributor

jmdobry commented Aug 16, 2017

@JustinBeckwith Looks good to you?

@jloveridge
Copy link

Please add a types property to package.json as well so that types are automatically discovered when the package is installed.

@martywins
Copy link

@notVitaliy Thanks for opening this!! Super keen for types!! 👍

@JustinBeckwith
Copy link
Contributor

This looks good! Just need to go add the types property to the package.json :) . Test failures look to be unrelated.

@martywins
Copy link

@JustinBeckwith thanks for your speedy reply! Assuming this gets merged soon, how long til the next release?

@JustinBeckwith JustinBeckwith merged commit 4fc7fd6 into googleapis:master Nov 5, 2017
@JustinBeckwith
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants