Allow access_type parameter to be overriden #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
approved these changes
Sep 19, 2017
| @@ -107,6 +112,7 @@ def __init__(self, oauth2session, client_type, client_config): | |||
| """Mapping[str, Any]: The OAuth 2.0 client configuration.""" | |||
| self.oauth2session = oauth2session | |||
| """requests_oauthlib.OAuth2Session: The OAuth 2.0 session.""" | |||
| self.redirect_uri = redirect_uri | |||
There was a problem hiding this comment.
There's already one for it below (it's a property)
| @@ -200,9 +206,9 @@ def authorization_url(self, **kwargs): | |||
| :class:`Flow` instance to obtain the token, you will need to | |||
| specify the ``state`` when constructing the :class:`Flow`. | |||
| """ | |||
| kwargs.setdefault('access_type', 'offline') | |||
There was a problem hiding this comment.
Probably worth updating the docstring to explain that access_type=offline will be added if not passed in?
| @@ -229,10 +235,9 @@ def fetch_token(self, **kwargs): | |||
| :meth:`credentials` to obtain a | |||
| :class:`~google.auth.credentials.Credentials` instance. | |||
| """ | |||
| kwargs.setdefault('client_secret', self.client_config['client_secret']) | |||
There was a problem hiding this comment.
It's okay if that happens (for now at least)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.