-
Notifications
You must be signed in to change notification settings - Fork 83
Accept redirect_uri as arg to flow creating classmethods. #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept redirect_uri as arg to flow creating classmethods. #17
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
I'm not sure. The The Add the redirect_uri to the kwargs and pass it to the class solves the problem, but I'm not sure the I can use only kwargs and pop Did I miss anything? |
It does accept a |
What a shame :) It is pretty clear reading the redirect_uri property :) Sorry by that, I will fix the PR now. |
Nothing to be sorry about! Thank you for doing this. :) |
The flow.py docstring tells that I could pass redirect_uri as argument to the classmethods
from_client_secrets_file
orfrom_config_file
, but this thing is broken with the 0.1.1 updates.I can still set the redirect_uri myself manually, but in this case, the docstring should be updated. I prefer to keep this approach, I mean, keep the redirect_uri as argument to the classmethods ;)
I also updated the tests, let me know if I missed anything.