Skip to content

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 8, 2021

Closes #595.

@tseaver tseaver requested review from arithmetic1728, silvolu and a team as code owners November 8, 2021 19:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2021
@arithmetic1728
Copy link
Contributor

I need the setuptools dependency for my mtls work (to add some C/C++ extension). Is there other way to solve the issue without dropping the dependency?

@tseaver
Copy link
Contributor Author

tseaver commented Nov 9, 2021

@arithmetic1728

I need the setuptools dependency for my mtls work (to add some C/C++ extension). Is there other way to solve the issue without dropping the dependency?

install_requires (which is what this PR changes) is about runtime dependencies, not build-time. Given that you are going to script building the C extension and releasing binary wheels using e.g. Github Workflow actions (as in python-crc32c) or some other mechanism, you can guarantee that setuptools is present during the build without having to declare it in setup.py.

Users of google-auth shouldn't need to have setuptools present in order to install the wheels you build in CI.

@arithmetic1728
Copy link
Contributor

@tseaver yep, you are right, thank you for the information!

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2021
@tseaver tseaver merged commit 47d4da6 into main Nov 9, 2021
@tseaver tseaver deleted the 595-drop-setuptools-dependency branch November 9, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setuptools as dependency is problematic w/ pip-tools
4 participants