Skip to content

Conversation

lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Feb 12, 2025

Update to use io.opentelemetry.semconv:opentelemetry-semconv (was io.opentelemetry:opentelemetry-semconv`). This version will be managed by shared-deps.

@lqiu96 lqiu96 requested review from a team as code owners February 12, 2025 18:33
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/java-firestore API. labels Feb 12, 2025
@lqiu96 lqiu96 changed the title deps: Update to io.opentelemetry.semconv:opentelemetry-semconv dep deps: Migrate to io.opentelemetry.semconv:opentelemetry-semconv dep Feb 12, 2025
@lqiu96
Copy link
Member Author

lqiu96 commented Feb 12, 2025

Error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce) on project google-cloud-firestore:
[ERROR] Rule 2: org.apache.maven.enforcer.rules.dependency.RequireUpperBoundDeps failed with message:
[ERROR] Failed while enforcing RequireUpperBoundDeps. The error(s) are [
[ERROR] Require upper bound dependencies error for io.opentelemetry.semconv:opentelemetry-semconv:1.26.0-alpha paths to dependency are:
[ERROR] +-com.google.cloud:google-cloud-firestore:3.30.8-SNAPSHOT
[ERROR]   +-io.opentelemetry.semconv:opentelemetry-semconv:1.26.0-alpha
[ERROR] and
[ERROR] +-com.google.cloud:google-cloud-firestore:3.30.8-SNAPSHOT
[ERROR]   +-com.google.cloud.opentelemetry:exporter-metrics:0.33.0
[ERROR]     +-io.opentelemetry.semconv:opentelemetry-semconv:1.27.0-alpha [runtime]
[ERROR] and
[ERROR] +-com.google.cloud:google-cloud-firestore:3.30.8-SNAPSHOT
[ERROR]   +-io.opentelemetry.instrumentation:opentelemetry-grpc-1.6:2.1.0-alpha
[ERROR]     +-io.opentelemetry.instrumentation:opentelemetry-instrumentation-api:2.1.0
[ERROR]       +-io.opentelemetry.semconv:opentelemetry-semconv:1.23.1-alpha [runtime]
[ERROR] and
[ERROR] +-com.google.cloud:google-cloud-firestore:3.30.8-SNAPSHOT
[ERROR]   +-io.opentelemetry.instrumentation:opentelemetry-grpc-1.6:2.1.0-alpha
[ERROR]     +-io.opentelemetry.instrumentation:opentelemetry-instrumentation-api-incubator:2.1.0-alpha
[ERROR]       +-io.opentelemetry.semconv:opentelemetry-semconv:1.23.1-alpha
[ERROR] ]

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Feb 12, 2025
Comment on lines +220 to +225
<dependency>
<groupId>io.opentelemetry.semconv</groupId>
<artifactId>opentelemetry-semconv</artifactId>
<version>1.26.0-alpha</version>
<scope>test</scope>
</dependency>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version will be managed by shared-deps in the next PR

@lqiu96 lqiu96 merged commit b3df19e into main Feb 12, 2025
23 checks passed
@lqiu96 lqiu96 deleted the otel-semconv-dep branch February 12, 2025 23:07
lqiu96 added a commit to renovate-bot/java-firestore that referenced this pull request Feb 12, 2025
…oogleapis#2014)

* deps: Update to io.opentelemetry.semconv:opentelemetry-semconv dep

* chore: generate libraries at Wed Feb 12 18:33:44 UTC 2025

* chore: Add exclusion for exporter-metrics

* chore: Migrate to new otel-semconv library

* chore: Add it as a test scope dep

---------

Co-authored-by: cloud-java-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants