ci: Design and implement a comprehensive performance regression presubmit/continuous job #4104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
…bmit/continuous job
sakthivelmanii
force-pushed
the
spanner_benchmarking
branch
from
a7a11e2 to
f8154ed
Compare
olavloite
reviewed
Oct 1, 2025
...le-cloud-spanner/src/test/java/com/google/cloud/spanner/benchmarking/BenchmarkValidator.java
Outdated
Show resolved
Hide resolved
...le-cloud-spanner/src/test/java/com/google/cloud/spanner/benchmarking/BenchmarkValidator.java
Outdated
Show resolved
Hide resolved
...cloud-spanner/src/test/java/com/google/cloud/spanner/benchmarking/MonitoringServiceImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/benchmarking/ReadBenchmark.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/benchmarking/ReadBenchmark.java
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/benchmarking/ReadBenchmark.java
Show resolved
Hide resolved
sakthivelmanii
force-pushed
the
spanner_benchmarking
branch
5 times, most recently
from
84a6780 to
a5a229d
Compare
olavloite
previously approved these changes
Oct 1, 2025
sakthivelmanii
force-pushed
the
spanner_benchmarking
branch
5 times, most recently
from
0a75e19 to
545ce98
Compare
sakthivelmanii
force-pushed
the
spanner_benchmarking
branch
from
545ce98 to
c635377
Compare
olavloite
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a framework for performance regression testing in the Java Spanner client library using JMH (Java Microbenchmark Harness), as outlined in our internal design document for performance regression detection.
Key Changes:
google.spanner.v1.Spanner/StreamingReadgoogle.spanner.v1.Spanner/ExecuteStreamingSqlPurpose:
The main objective is to establish an automated system to detect performance regressions within the client library code before they impact users. This setup helps ensure that changes and new features do not negatively affect the library's latency and throughput.
Internal Reference: b/414281827