Skip to content

Conversation

GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

b/436988929

@GarrettWu GarrettWu requested a review from sycai August 26, 2025 23:56
@GarrettWu GarrettWu self-assigned this Aug 26, 2025
@GarrettWu GarrettWu requested review from a team as code owners August 26, 2025 23:56
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 26, 2025
sycai
sycai previously approved these changes Aug 27, 2025
@@ -79,6 +79,30 @@ def batch_convert_to_series(
)


def batch_convert_to_bf_array_type(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming nit: "batch_convert_to_bf_equivalent"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@GarrettWu GarrettWu enabled auto-merge (squash) August 27, 2025 18:34
@GarrettWu GarrettWu merged commit 2c72c56 into main Aug 27, 2025
18 of 25 checks passed
@GarrettWu GarrettWu deleted the garrettwu-split branch August 27, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants