Skip to content

fix: Use warning instead of warn in system tests to avoid DeprecationWarning #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2023
Merged

fix: Use warning instead of warn in system tests to avoid DeprecationWarning #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7e86ef
fix: Use warning instead of warn in system tests to avoid
gkevinzheng Dec 4, 2023
4dd9a01
Merge branch 'main' into use-warning
gkevinzheng Dec 5, 2023
1df784e
Removed ignore like from pytest.ini
gkevinzheng Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,5 @@ filterwarnings =
ignore:datetime.datetime.utcfromtimestamp\(\) is deprecated:DeprecationWarning:google.cloud.logging_v2.handlers.transports
ignore:datetime.datetime.utcnow\(\) is deprecated:DeprecationWarning:tests.unit.test__http
ignore:datetime.datetime.utcnow\(\) is deprecated:DeprecationWarning:tests.unit.test_entries
# Remove once https://github.com/googleapis/python-logging/issues/820 is fixed
ignore:.*warn.*is deprecated, use.*warning.*instead:DeprecationWarning
# Remove once a version of grpcio newer than 1.59.3 is released to PyPI
ignore:datetime.datetime.utcnow\(\) is deprecated:DeprecationWarning:grpc._channel
4 changes: 2 additions & 2 deletions tests/system/test_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ def test_handlers_w_extras(self):
"resource": Resource(type="cloudiot_device", labels={}),
"labels": {"test-label": "manual"},
}
cloud_logger.warn(LOG_MESSAGE, extra=extra)
cloud_logger.warning(LOG_MESSAGE, extra=extra)

entries = _list_entries(logger)
self.assertEqual(len(entries), 1)
Expand Down Expand Up @@ -634,7 +634,7 @@ def test_handlers_w_json_fields(self):
cloud_logger = logging.getLogger(LOGGER_NAME)
cloud_logger.addHandler(handler)
extra = {"json_fields": {"hello": "world", "two": 2}}
cloud_logger.warn(LOG_MESSAGE, extra=extra)
cloud_logger.warning(LOG_MESSAGE, extra=extra)

entries = _list_entries(logger)
self.assertEqual(len(entries), 1)
Expand Down