Skip to content

fix: Added type hints to CloudLoggingHandler constructor #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2024
Merged

fix: Added type hints to CloudLoggingHandler constructor #903

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64df8b9
fix: Added type hints to CloudLoggingHandler constructor
gkevinzheng Jun 6, 2024
2440bd2
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jun 6, 2024
b7ecaf6
Removed Client typing due to circular imports
gkevinzheng Jun 6, 2024
9d7e0dd
Merge branch 'main' into constructor-typing
gkevinzheng Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions google/cloud/logging_v2/handlers/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,19 @@
import json
import logging

from google.cloud.logging_v2.handlers.transports import BackgroundThreadTransport
from typing import Optional, IO

from google.cloud.logging_v2.handlers.transports import (
BackgroundThreadTransport,
Transport,
)
from google.cloud.logging_v2.handlers._monitored_resources import (
detect_resource,
add_resource_labels,
)
from google.cloud.logging_v2.handlers._helpers import get_request_data
from google.cloud.logging_v2.resource import Resource


DEFAULT_LOGGER_NAME = "python"

Expand Down Expand Up @@ -149,11 +156,11 @@ def __init__(
self,
client,
*,
name=DEFAULT_LOGGER_NAME,
transport=BackgroundThreadTransport,
resource=None,
labels=None,
stream=None,
name: str = DEFAULT_LOGGER_NAME,
transport: Transport = BackgroundThreadTransport,
resource: Resource = None,
labels: Optional[dict] = None,
stream: Optional[IO] = None,
**kwargs,
):
"""
Expand Down