Skip to content

fix: make logging handler close conditional to having the transport opened #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

fix: make logging handler close conditional to having the transport opened #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions google/cloud/logging_v2/handlers/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,10 @@ def flush(self):

def close(self):
"""Closes the log handler and cleans up all Transport objects used."""
self.transport.close()
self.transport = None
self._transport_open = False
if self._transport_open:
self.transport.close()
self.transport = None
self._transport_open = False


def _format_and_parse_message(record, formatter_handler):
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/handlers/test_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,10 @@ def test_close(self):
self.assertFalse(handler._transport_open)
self.assertTrue(old_transport.close_called)

# second call to close shouldn't throw an exception
handler.close()
self.assertFalse(handler._transport_open)


class TestFormatAndParseMessage(unittest.TestCase):
def test_none(self):
Expand Down