Skip to content

chore: restrict internet access when running docker container in integration test #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

chore: restrict internet access when running docker container in integration test #3384

merged 1 commit into from
Nov 19, 2024

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented Nov 19, 2024 •
edited
Loading

A verification step in go/offline-gen-design

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 19, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review November 19, 2024 18:37
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JoeWang1127 JoeWang1127 merged commit 1080de4 into main Nov 19, 2024
49 of 55 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/restrict-internet branch November 19, 2024 19:28
meltsufin
meltsufin reviewed Nov 19, 2024
View reviewed changes
hermetic_build/library_generation/tests/integration_tests.py
Comment on lines +306 to +307
"--network",
"none",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin left review comments

@diegomarquezp diegomarquezp diegomarquezp approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeWang1127 @meltsufin @diegomarquezp