Fragment can't receive onRequestPermissionsResult after showing RationaleDialog

[b95505017]

If we call EasyPermissions.requestPermissions from Fragment and show rational dialog:

    @Override
    public void showRequestPermissionRationale(@NonNull String rationale,
                                               @NonNull String positiveButton,
                                               @NonNull String negativeButton,
                                               @StyleRes int theme,
                                               int requestCode,
                                               @NonNull String... perms) {

        FragmentManager fm = getSupportFragmentManager();

https://github.com/googlesamples/easypermissions/blob/master/easypermissions/src/main/java/pub/devrel/easypermissions/helper/BaseSupportPermissionsHelper.java#L32

    @Override
    public FragmentManager getSupportFragmentManager() {
        FragmentActivity hostActivity = getHost().getActivity();
        if (hostActivity != null) {
            return hostActivity.getSupportFragmentManager();
        } else {
            return getHost().getChildFragmentManager();
        }
    }

This will return hostActivity.getSupportFragmentManager(), causing request permissions using ActivityCompat.requestPermissions(xxx), this way the host fragment can't receive onRequestPermissionsResult, only its host Activity.

[SUPERCILEX]

Ouch! That completely slipped my mind, sorry @samtstern. 😊 @b95505017 this should be fixed soon.

[samtstern]

@b95505017 thanks for raising this and @SUPERCILEX thanks for the quick fix!

[b95505017]

Thanks for your help!

[samtstern]

@b95505017 I will put out a release that includes this fix soon.

[samtstern]

Released 3.1.3.

[b95505017]

@samtstern Should be 1.1.3, thanks!

[samtstern]

Oops yeah!

…

On Thu, Jan 25, 2018, 12:59 PM Yu-Hsuan Lin ***@***.***> wrote: @samtstern <https://github.com/samtstern> Should be 1.1.3, thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#198 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIEw6uAdyhFbHRlYNrIYdd_ypufUjdfjks5tOOs1gaJpZM4RsrHZ> .