Skip to content
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Removed "android:supportsRtl" #2

Merged
merged 1 commit into from
Dec 24, 2015
Merged

Removed "android:supportsRtl" #2

merged 1 commit into from
Dec 24, 2015

Conversation

alirezaafkar
Copy link
Contributor

Removed "android:supportsRtl" attribute from manifest because of "Manifest merger failed"

adding tools:replace"android:supportsRtl" to my application element didn't fix the problem.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@alirezaafkar
Copy link
Contributor Author

I signed it!

</application>

<manifest package="com.google.example.easypermissions">
<application/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer valid XML. How about this:

<manifest package="com.google.example.easypermissions">
    <application 
            android:label="@string/app_name">
    </application>
</manifest>

@alirezaafkar
Copy link
Contributor Author

@samtstern I think it was valid! but this is okay too :)

@samtstern
Copy link
Contributor

Oops you're right it was valid! So what we really want is your XML but without removing the xmlns from the Manifest tag and the label from the application tag.

samtstern added a commit that referenced this pull request Dec 24, 2015
Removed "android:supportsRtl"
@samtstern samtstern merged commit fffb1b2 into googlesamples:master Dec 24, 2015
@samtstern samtstern mentioned this pull request Jan 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants