Skip to content

support for go 1.17? #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
encryptblockr opened this issue Sep 6, 2021 · 4 comments · Fixed by #242
Closed

support for go 1.17? #235

encryptblockr opened this issue Sep 6, 2021 · 4 comments · Fixed by #242

Comments

@encryptblockr
Copy link

Current docker image is using go 1.11.4 but current stable version of go is 1.17
Is there a path to maybe modifying Dockerfile to build image to use go 1.17?
Please let me/us know if this is possible and any list of steps to guide to solution

Thanks

/ # go version
go version go1.11.4 linux/amd64

/ # go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build558705597=/tmp/go-build -gno-record-gcc-switches"
@encryptblockr
Copy link
Author

how do we update go to latest version?

currently here is version of go with latest gophernotes docker image

# go version
go version go1.11.4 linux/amd64

how do we update to use go 1.17.0?

@cosmos72
Copy link
Member

cosmos72 commented Jan 9, 2022

The Dockerfile.* probably needs to be updated. @sbinet maybe can help?

@sbinet
Copy link
Member

sbinet commented Jan 11, 2022

sure. I'll wait for a couple of days to give a bit of time for #238 to be updated and merged, so as to not duplicate work (nor deter new contributors)

sbinet added a commit to sbinet-gonum/gophernotes that referenced this issue Jan 25, 2022
sbinet added a commit to sbinet-gonum/gophernotes that referenced this issue Jan 25, 2022
sbinet added a commit to sbinet-gonum/gophernotes that referenced this issue Jan 25, 2022
@sbinet
Copy link
Member

sbinet commented Jan 25, 2022

ok, #238 timed out.
see:

sbinet added a commit that referenced this issue Jan 26, 2022
Fixes #235.

Signed-off-by: Sebastien Binet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants