Skip to content

feat: add tolerations, affinity, volumes & volumeMounts #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 18, 2023
Merged

feat: add tolerations, affinity, volumes & volumeMounts #9

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
adde342
feat: add taint/tolerations
ishanarya0 Apr 13, 2023
c88d67b
chore: taints enabled check
ishanarya0 Apr 13, 2023
50766d1
fix: change name to tolearion and type array
ishanarya0 Apr 13, 2023
d76d2f7
feat: add affinity
ishanarya0 Apr 13, 2023
d5e43f7
feat: add both nodeAffinity
ishanarya0 Apr 13, 2023
2c91054
feat: add volumes and volumeMounts
ishanarya0 Apr 14, 2023
9a12cdb
fix: values
ishanarya0 Apr 14, 2023
41d7fc8
fix: add volume and mounts key only if needed
ishanarya0 Apr 14, 2023
d2324d6
feat: upgrade version and docs
ishanarya0 Apr 17, 2023
c680e07
feat: upgrade version and docs
ishanarya0 Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions stable/firehose/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ spec:
- mountPath: /work-dir
name: workdir
{{- end }}
{{- if or (gt (len .Values.volumeMounts) 0) }}
{{- range $_, $volumeMount := .Values.volumeMounts }}
- name: {{ $volumeMount.name}}
mountPath: {{ $volumeMount.mountPath }}
{{- end}}
{{- end}}
resources:
{{- toYaml .Values.firehose.resources | nindent 12 }}
envFrom:
Expand Down Expand Up @@ -85,3 +91,51 @@ spec:
- emptyDir: {}
name: workdir
{{- end }}
{{- if or (gt (len .Values.volumes) 0) }}
{{- range $_, $volume := .Values.volumes }}
- name: {{ $volume.name}}
secretName: {{ $volume.secretName }}
defaultMode: {{ $volume.defaultMode }}
items: {{- range $_, $item := $volume.items }}
- key: {{ $item.key }}
path: {{ $item.path }}
{{- end}}
{{- end}}
{{- end}}

{{- if (gt (len .Values.tolerations) 0) }}
tolerations: {{- range $_, $toleration := .Values.tolerations }}
- key: {{ $toleration.key }}
operator: {{ $toleration.operator }}
value: {{ $toleration.value }}
effect: {{ $toleration.effect }}
{{- end }}
{{- end}}
{{- if or (gt (len .Values.nodeAffinitiyMatchExpressions.requiredDuringSchedulingIgnoredDuringExecution) 0) (gt (len .Values.nodeAffinitiyMatchExpressions.preferredDuringSchedulingIgnoredDuringExecution) 0) }}
affinity:
nodeAffinity:
{{- if (gt (len .Values.nodeAffinitiyMatchExpressions.requiredDuringSchedulingIgnoredDuringExecution) 0) }}
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions: {{- range $_, $expression := .Values.nodeAffinitiyMatchExpressions.requiredDuringSchedulingIgnoredDuringExecution }}
- key: {{ $expression.key }}
operator: {{ $expression.operator }}
values: {{- range $expression.values }}
- {{ . }}
{{- end}}
{{- end}}
{{- end}}
{{- if (gt (len .Values.nodeAffinitiyMatchExpressions.preferredDuringSchedulingIgnoredDuringExecution) 0) }}
preferredDuringSchedulingIgnoredDuringExecution: {{- range $_, $expression := .Values.nodeAffinitiyMatchExpressions.preferredDuringSchedulingIgnoredDuringExecution }}
- weight: {{ $expression.weight}}
preference:
matchExpressions: {{- range $_, $pref := $expression.preference }}
- key: {{ $pref.key }}
operator: {{ $pref.operator }}
values: {{- range $pref.values }}
- {{ . }}
{{- end}}
{{- end}}
{{- end}}
{{- end}}
{{- end}}
10 changes: 10 additions & 0 deletions stable/firehose/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,16 @@ firehose:
cpu: 200m
memory: 512Mi

tolerations: []

volumes: []

volumeMounts: []

nodeAffinitiyMatchExpressions:
requiredDuringSchedulingIgnoredDuringExecution: []
preferredDuringSchedulingIgnoredDuringExecution: []

init-firehose:
enabled: false
image:
Expand Down