This repository was archived by the owner on Aug 26, 2021. It is now read-only.
Read from src, utilise workspaces, update packages #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2019 17:12
* First steps with yarn workspaces * Switched sass imports to read from src Setup yarn workspaces First attempt at modifying helper.js * Removed pancake folder * Upgraded babel and webpack * Updated circleci image and build process * Upgraded webpack ES6 for babel-loader Upgraded ES6 helper babel process * Commented out devDep checks, need to rewrite * Added node-module caching to circleci * Put restore_cache key in wrong order :'( * Removed pancake root key Gave module versions some love Updated circleci comments * Package formatting * Installed mocha/chai over jest, removed jest * Updated 50% of unit tests * Renamed packages -> components * Installed babel preset minify * added preset to .babelrc * updated README.md * Trailing process.exit for circleci * Updated autoprefixer tag to be inline with spec Trialing node direct script over yarn * Added mode flag to webpack config - creates warning in webpack 4 * Playing around with puppetter args and circle images * Removed debug flags, trying node image * Updated circleci image * Helper should read from src for file check and build to lib/ * Correct webpack config to reference babel-preset-minify as a plugin not preset * Removed all instances of babel-preset-minify * Various tweaks based on PR review * Added back missing spacing * Added back es5 name convention * Webpack formatting * Forgot es5 name convention * Dependency shuffling * Added back ES6 dep comment * Trailing why git thinks _deps is new * Updated webpack output location Reverted helper react.es5.js changes back Added gitignore for react/tests/dist Updated ES6 dependency imports to pancake root folder * Added nuke script for pancake/ * Temporary resolved yarn workspace building by pretending animate requires sass * Added missing sass: name false key to animate * Reverted pretending animate hass sass * Resolved root and core vulnerabilities * Added missing whitespace in core * Updated engines, removed verbose --pancake from animate * Added back webpack ./bundle.js -> bundle.js * Updated local install instructions for yarn and grammar * Updated FAQ notes for yarn * Updated auds.json from latest develop * Upgraded circle node images to latest lts
azerella
added
enhancement
azerella
changed the title
|
@sukhrajghuman Packages have been updated in |
sukhrajghuman
approved these changes
Feb 22, 2019
|
here goes 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #602
fixes #603
fixes #497
Let's try out the new Yarn workspace workflow for real.
Like the notes mention here: #603
We will need to publish ( thanks to new autoprefixer details ):