Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

Added react proptype jsdoc #725

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Added react proptype jsdoc #725

merged 2 commits into from
Apr 10, 2019

Conversation

azerella
Copy link
Contributor

@azerella azerella commented Apr 8, 2019 •
edited
Loading

  • Adding jsdoc comments, still incomplete but a start. Having jsdoc on our react prop types allows us to auto generate using react-docgen

@azerella azerella requested a review from sukhrajghuman April 8, 2019 01:28
@azerella azerella added the documentation Issue or pull request related to documentation. label Apr 8, 2019
@azerella azerella added this to the Sprint 127 milestone Apr 8, 2019
@azerella azerella self-assigned this Apr 8, 2019
@azerella azerella mentioned this pull request Apr 8, 2019
Closed
4 tasks
@azerella azerella force-pushed the feature/add-react-jsdoc branch from 295861f to ad279b1 Compare April 10, 2019 01:17
@azerella azerella changed the base branch from feature/decouple-react-files to feature/seperate-react-files April 10, 2019 01:18
@azerella azerella mentioned this pull request Apr 10, 2019
Open
1 task
@azerella azerella changed the title Added basic react proptype jsdoc Added react proptype jsdoc Apr 10, 2019
@azerella azerella merged commit 467b96c into feature/seperate-react-files Apr 10, 2019
@azerella azerella deleted the feature/add-react-jsdoc branch April 10, 2019 01:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@sukhrajghuman sukhrajghuman sukhrajghuman approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@azerella azerella

Labels
documentation Issue or pull request related to documentation.
Projects
None yet
Milestone
Sprint 127
Development

Successfully merging this pull request may close these issues.
2 participants
@azerella @sukhrajghuman