Skip to content

enhance: pretty-print JSON arguments for OpenAPI operations #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2024
Merged

enhance: pretty-print JSON arguments for OpenAPI operations #808

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a51fdb
enhance: pretty-print JSON arguments for OpenAPI operations
g-linville Aug 20, 2024
260bbea
PR feedback
g-linville Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/types/toolstring.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,16 @@ func ToSysDisplayString(id string, args map[string]string) (string, error) {
return "", nil
case "sys.openapi":
if os.Getenv("GPTSCRIPT_OPENAPI_REVAMP") == "true" && args["operation"] != "" {
return fmt.Sprintf("Running API operation `%s` with arguments %s", args["operation"], args["args"]), nil
// Pretty print the JSON by unmarshaling and marshaling it
var jsonArgs map[string]interface{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
var jsonArgs map[string]interface{}
var jsonArgs map[string]any

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I blame copilot lol

if err := json.Unmarshal([]byte(args["args"]), &jsonArgs); err != nil {
return "", err
}
jsonPretty, err := json.MarshalIndent(jsonArgs, "", " ")
if err != nil {
return "", err
}
return fmt.Sprintf("Running API operation `%s` with arguments %s", args["operation"], string(jsonPretty)), nil
}
fallthrough
default:
Expand Down