forked from oracle/graal
-
Notifications
You must be signed in to change notification settings - Fork 16
[CI] Enable assertions #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zakkak
wants to merge
1
commit into
graalvm:default
Choose a base branch
from
zakkak:2025-08-25-enable-assertions
base: default
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1836bd9
to
e487009
Compare
jerboaa
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM provided CI is fine with this.
Depends on: oracle#12042 |
e487009
to
c4b0c0d
Compare
JDK 26+13 is available via labs by now. That isn't a blocker. We see a couple of assertions fired with this though. Example:
or
|
c4b0c0d
to
71662f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
testing
CI and testing related issues and PRs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as draft till upstream graal updates to JDK 26+12, as it currently fails with:
due to openjdk/jdk@655dc51#diff-42f5711b7bc39a45a6e647f8e09e69eab24556a282f272017d9b33b42911ee35
Closes #846