This repository was archived by the owner on Jan 23, 2025. It is now read-only.
Limit # of requests per service #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xujiaxj
reviewed
Mar 9, 2023
| ) | ||
|
|
||
| type serviceQueues struct { | ||
| config *Config |
There was a problem hiding this comment.
Nit: taking a reference to the whole Config seems unnecessary. Just copying the two limit settings is better.
There was a problem hiding this comment.
I was in two minds about it but decided to keep the pointer. It looks like both pointer and int are 8 bytes on 64bit OS. So it's more efficient to use the pointer instead of two int types.
This reverts commit 26ae3ab.
nandadev
reviewed
Mar 10, 2023
| type serviceQueues struct { | ||
| config *Config | ||
| requestStates *sync.Map | ||
| requestCount int |
There was a problem hiding this comment.
requestStates is a map. Why not use map's len function instead of having a separate variable to track the map size?
There was a problem hiding this comment.
See golang/go#20680.
Guess a len function on a current map is not preferred by the library developer. Java ConcurrentHashMap has the same concern about performance.
nandadev
approved these changes
Mar 10, 2023
xujiaxj
approved these changes
Mar 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ch14893]
Limit # of requests per service in addition to rate limiting at a per request level within a service