Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

jtlisi
Copy link
Contributor

@jtlisi jtlisi commented Jun 3, 2020

Update the mixin to respect the adjustment to metrics added in cortexproject/cortex#2648

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtlisi jtlisi force-pushed the 20200603_respect_kv_name branch from c963199 to c867c3c Compare June 3, 2020 21:02
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would just suggest to merge it once the Cortex rollout (including these changes) is either in progress or completed.

@jtlisi jtlisi merged commit 59dc335 into master Jun 4, 2020
@jtlisi jtlisi deleted the 20200603_respect_kv_name branch June 4, 2020 13:58
@jtlisi jtlisi restored the 20200603_respect_kv_name branch June 4, 2020 15:31
jtlisi added a commit that referenced this pull request Jun 4, 2020
@tomwilkie tomwilkie deleted the 20200603_respect_kv_name branch June 23, 2020 18:17
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants