Skip to content

Crash on diagnostics, VSCode #49

@jkmnt

Description

@jkmnt

Empty jsonnet file, pressing ctrl+enter for suggestions/diagnostic after s crashes the server

{
 s
}

debug output:

time="2022-08-23T04:41:32+03:00" level=info msg="Starting the language server"
time="2022-08-23T04:41:32+03:00" level=info msg="Using tanka mode. Will fall back to the following jpaths: []"
time="2022-08-23T04:41:32+03:00" level=info msg="Initializing jsonnet-language-server version 0.7.2"
time="2022-08-23T04:41:32+03:00" level=info msg="Reading stdlib"
panic: runtime error: index out of range [9] with length 0

goroutine 51 [running]:
github.com/grafana/jsonnet-language-server/pkg/server.(*server).getEvalDiags(0xa03ec8?, 0xc00011a000)
	/home/runner/work/jsonnet-language-server/jsonnet-language-server/pkg/server/diagnostics.go:153 +0x629
github.com/grafana/jsonnet-language-server/pkg/server.(*server).diagnosticsLoop.func1.1.1()
	/home/runner/work/jsonnet-language-server/jsonnet-language-server/pkg/server/diagnostics.go:55 +0x2a
created by github.com/grafana/jsonnet-language-server/pkg/server.(*server).diagnosticsLoop.func1.1
	/home/runner/work/jsonnet-language-server/jsonnet-language-server/pkg/server/diagnostics.go:54 +0x238
[Info  - 04:41:33] Connection to server got closed. Server will restart.

VSCode 1.70.2
jsonnet-language-server 0.7.2
vscode-jsonnet: 0.2.4
windows

Looking into the sources of diagnostics.go suggests the fail of regexp match: there is match[9] access,
but match is likely to be empty.

   diag.Message = match[9]
   diag.Severity = protocol.SeverityError

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions