Skip to content

Invalidate the whole "top level objects" cache #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Invalidate the whole "top level objects" cache #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pkg/cache/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"errors"
"fmt"
"os"
"path/filepath"
"strings"
"sync"

Expand Down Expand Up @@ -56,11 +55,9 @@ func (c *Cache) Put(new *Document) error {
c.docs[uri] = new

// Invalidate the TopLevelObject cache
for k := range c.topLevelObjects {
if strings.HasSuffix(k, filepath.Base(uri.SpanURI().Filename())) {
delete(c.topLevelObjects, k)
}
}
// We can't easily invalidate the cache for a single file (hard to figure out where the import actually leads),
// so we just clear the whole thing
c.topLevelObjects = make(map[string][]*ast.DesugaredObject)

return nil
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ func (s *Server) DidChange(_ context.Context, params *protocol.DidChangeTextDocu
}
}
}
return nil

return s.cache.Put(doc)
}

func (s *Server) DidOpen(_ context.Context, params *protocol.DidOpenTextDocumentParams) (err error) {
Expand Down