Split find into multiple files #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are the main feature of this PR: * Processing functions are split into multiple files * Tests are unmodified, they still pass the same way * Finding a field now returns an array of `objectRange` instead of a field directly. This will allow us to implement issues that require multiple definitions (such as listing overrides and getting autocomplete) * Finding a parameter has been split from finding a var bind
|
We can check all of this out after holidays @zzehring. These PRs will allow us to go forward on harder features |
zzehring
approved these changes
Jan 6, 2022
Yeah, probably some renaming is in order. I'll wait till we get into new features, we'll probably shuffle some things around even more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the main feature of this PR:
objectRangeinstead of a field directly. This will allow us to implement issues that require multiple definitions (such as listing overrides and getting autocomplete)