Skip to content

Conversation

julienduchesne
Copy link
Collaborator

Follow-up to #23
See the test file for examples. Fetching self.sub2 and self.test3 now works!

Follow-up to #23
See the test file for examples. Fetching `self.sub2` and `self.test3` now works!
@julienduchesne julienduchesne changed the title Complex self scope improvements self complex scope improvements Jan 25, 2022
Base automatically changed from julienduchesne/fix-self-scope to main January 27, 2022 11:32
Copy link
Contributor

@zzehring zzehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks :chefs_kiss:! Really like what you did with the comments in the test jsonnet file. Think when we get together a more comprehensive contributing guide, I'd like to see more of that type of annotation.

@julienduchesne julienduchesne merged commit 4a094f7 into main Feb 9, 2022
@julienduchesne julienduchesne deleted the julienduchesne/more-self-cases branch February 9, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants